Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(windows, ip-address): add ipAddress info to windows details #581

Merged
merged 1 commit into from Mar 2, 2022

Conversation

mikehardy
Copy link
Contributor

Overview

Add ipAddress information to netinfo details on windows platform

This is a straight copy from the device info package, as mentioned in react-native-device-info/react-native-device-info#1387 and Fixes #580

Test Plan

Works for me locally in testing the netinfo example on windows, after release I nominate @thnszgns to confirm it works in practice

@mikehardy mikehardy added the pending merge A PR that will be merged shortly, waiting for CI or final comment label Mar 2, 2022
@mikehardy
Copy link
Contributor Author

This is a copy/paste of working code from the device-info module so it should be at least good enough to release thus I will do so, but if any of @jfkm69 or @aschultz or @jonthysell has a chance to check it, chuckle at how I'm obviously a Windows C++ hack (Full disclosure: I am not actually good enough at Windows C++ to even be a hack, actually), and/or make it better, I'd be much obliged

@mikehardy mikehardy merged commit 11f3e3b into master Mar 2, 2022
@mikehardy mikehardy deleted the @mikehardy/windows-ip-address branch March 2, 2022 14:49
@mikehardy mikehardy removed the pending merge A PR that will be merged shortly, waiting for CI or final comment label Mar 2, 2022
github-actions bot pushed a commit that referenced this pull request Mar 2, 2022
# [8.1.0](v8.0.0...v8.1.0) (2022-03-02)

### Features

* **windows, ip-address:** add ipAddress info to windows details ([#581](#581)) ([11f3e3b](11f3e3b))
@matt-oakes
Copy link
Collaborator

🎉 This PR is included in version 8.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@thnszgns
Copy link

thnszgns commented Mar 2, 2022

I am sorry I can't confirm, I updated to 8.1.0 but I don't see ipAddress available in details.

details:
bssid: null
cellularGeneration: null
frequency: null
isConnectionExpensive: false
ssid: null
strength: null
wifiGeneration: null

@mikehardy
Copy link
Contributor Author

Please triple-check that you have actually loaded the new code + bundle, check the example app if necessary (note the two windows-specific package.json run scripts for testing), this definitely worked for me locally using the example.

@thnszgns
Copy link

thnszgns commented Mar 2, 2022

Sorry for my last message! I did a new build one more time and it worked! I am not sure what was the problem, I did the exact same thing as before.

@mikehardy
Copy link
Contributor Author

Excellent news though! Probably sunspots, or solar particles ;-). Thanks for checking + confirming. This was my first react-native-windows code ever. Of course, just a copy/paste of already working code from somewhere else but the work simply to get to that point has been slow going for me, I'm pleased it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows should fetch IP address if possible
3 participants