Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android): add ethernet information #584

Merged
merged 1 commit into from Mar 18, 2022
Merged

feat(android): add ethernet information #584

merged 1 commit into from Mar 18, 2022

Conversation

giautm
Copy link
Contributor

@giautm giautm commented Mar 17, 2022

Overview

Close: #536

Test Plan

Run example on Real Device

@giautm giautm requested a review from matt-oakes as a code owner March 17, 2022 05:21
mikehardy
mikehardy approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Sorry for the delay checking this out, it looks really good
Once CI goes green this looks ready to merge+release

@mikehardy mikehardy changed the title feat: support ethernet information feat(android): add ethernet information Mar 18, 2022
@mikehardy
Copy link
Contributor

Checks out in local testing on an android emulator, but those don't have an ethernet connection and even when I set up an AndroidTV emulator it connects via wifi 😅 so there's no way to test this on emulators that I can see? I assume you have a TV device (or a dongle?) that works with Android so that it has an ethernet connection and test this? I'll merge it (which should trigger a release) I guess I'm curious what the hardware target is, for future reference

@mikehardy mikehardy merged commit 2b3a8e2 into react-native-netinfo:master Mar 18, 2022
github-actions bot pushed a commit that referenced this pull request Mar 18, 2022
@semantic-release-bot
chore(release): 8.2.0 [skip ci]
f05f7dd 
# [8.2.0](v8.1.0...v8.2.0) (2022-03-18)

### Features

* **android:** add ethernet information ([#584](#584)) ([2b3a8e2](2b3a8e2))
@matt-oakes
Copy link
Collaborator

🎉 This PR is included in version 8.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@giautm
Copy link
Contributor Author

giautm commented Mar 18, 2022

Checks out in local testing on an android emulator, but those don't have an ethernet connection and even when I set up an AndroidTV emulator it connects via wifi 😅 so there's no way to test this on emulators that I can see? I assume you have a TV device (or a dongle?) that works with Android so that it has an ethernet connection and test this? I'll merge it (which should trigger a release) I guess I'm curious what the hardware target is, for future reference

I have tested by using an Android Tablet (SS A7 Lite) and Type-C Hub with Ethernet port (any Hub for Macbook will work). Then, I plug the hub to the tablet, and of course, Internet cable. :D

@giautm giautm deleted the ethernet branch March 18, 2022 18:21
@mikehardy
Copy link
Contributor

Ah interesting! I think I have a macbook hub like that and a phone that will accept it. Will have to give it a test as time allows. Until then, it's out! Enjoy :-) 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehardy mikehardy mikehardy approved these changes

@matt-oakes matt-oakes Awaiting requested review from matt-oakes matt-oakes is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support more details for ethernet on Android (Maybe also VPN)
3 participants
@giautm @mikehardy @matt-oakes