feat: add imperative api to refresh state

[roryabraham]

Fixes #593

Overview

This pull request implements a new imperative API called refresh to update NetInfo's state by forcing the native interface to recompute the library's internal state. More detailed in the linked issue 🙂

Test Plan

Keeping the tests pretty simple for now:

1. Run yarn start:web to run the example web app.
2. Open and clear the network console.
3. Tap on NetInfo.fetch – observe that no network request is made to retest internet reachability.
4. Tap on NetInfo.refresh – observe that a network request is made to retest internet reachability.

There's certainly more that could be done to test this, but personally this is enough to make me confident that this is working as expected.

Screen.Recording.2022-04-05.at.11.43.23.PM.mov

[roryabraham]

@matt-oakes Just throwing out an alternate solution – we could also make fetch just do what refresh does now (i.e: always _fetchCurrentState). I'm not sure if there are performance reasons why that would be ill-advised, but it seems kind of unlikely to me that anyone using the fetch API would not want the most up-to-date state possible.

Edit: @mikehardy convinced me the a separate imperative refresh is better: #593 (comment)

[roryabraham]

Hiya 👋 Friendly reminder that this PR is ready for review 🙂

[mikehardy]

Nice! This looks really good, thank you

The only thing I can think of is an addition to the mock

react-native-netinfo/jest/netinfo-mock.js

Line 23 in f05f7dd

RNCNetInfoMock.fetch.mockResolvedValue(defaultState);

Otherwise looks good?

Sorry for the delay, one of the repos I'm in participates in Google Summer of Code and we had 50 applicants raining PRs on us for the last couple weeks, it has been nutty 🤯

https://github.com/ankidroid/Anki-Android/pulse/monthly

[roryabraham]

Thanks for the review! That's a lot of PRs 😄

Updated the Jest mocks. I'm a bit of a noob when it comes to Jest, so I'm not sure how to test that it works as expected. Let me know if you need further changes. Happy to adjust the PR as needed 👍

[mikehardy]

I think that's exactly "the needful", this looks great to me, let's go!

[matt-oakes]

🎉 This PR is included in version 8.3.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[roryabraham]

Awesome, thanks so much!