Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: web module removeListeners #600

Merged
merged 1 commit into from May 30, 2022
Merged

Conversation

gdoudeng
Copy link
Contributor

Overview

Fix web module issue when removeListeners

Test Plan

@gdoudeng gdoudeng requested a review from matt-oakes as a code owner May 29, 2022 07:10
Copy link
Contributor

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! That's a pretty obvious error, I cannot believe that was just sitting there in plain sight. Thanks for noticing it and thanks especially for sending in a PR to just fix it, very much appreciated

@mikehardy mikehardy merged commit 60e9e38 into react-native-netinfo:master May 30, 2022
github-actions bot pushed a commit that referenced this pull request May 30, 2022
## [8.3.1](v8.3.0...v8.3.1) (2022-05-30)

### Bug Fixes

* **web:** removeListeners should actually remove listeners ([#600](#600)) ([60e9e38](60e9e38))
@matt-oakes
Copy link
Collaborator

🎉 This PR is included in version 8.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants