Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add linkSpeed, rxLinkSpeed, txLinkSpeed info to wifi on android #605

Merged
merged 2 commits into from Jun 28, 2022
Merged

feat: add linkSpeed, rxLinkSpeed, txLinkSpeed info to wifi on android #605

merged 2 commits into from Jun 28, 2022

Conversation

wtlyu
Copy link
Contributor

@wtlyu wtlyu commented Jun 10, 2022

…droid. (#604)

Overview

close ( #604 )
This will add linkSpeed, rxLinkSpeed, txLinkSpeed to the details, when wifi and android platform.

Test Plan

Run example on Real Device

@wtlyu wtlyu requested a review from matt-oakes as a code owner June 10, 2022 12:23
@wtlyu wtlyu changed the title feat: add linkSpeed, rxLinkSpeed, txLinkSpeed info to wifi mode on an… feat: add linkSpeed, rxLinkSpeed, txLinkSpeed info to wifi on android Jun 10, 2022
mikehardy
mikehardy approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! This looks good to me, thanks!

@mikehardy mikehardy added the pending merge A PR that will be merged shortly, waiting for CI or final comment label Jun 28, 2022
@mikehardy
Copy link
Contributor 


Error:   35:62  error    Delete `,`                                                                                                                  prettier/prettier
Error:   58:39  error    Replace `⏎··NetInfoDisconnectedState<NetInfoStateType.none` with `·NetInfoDisconnectedState<⏎··NetInfoStateType.none⏎`      prettier/prettier
Error:   85:36  error    Replace `⏎··NetInfoConnectedState<NetInfoStateType.bluetooth` with `·NetInfoConnectedState<⏎··NetInfoStateType.bluetooth⏎`  prettier/prettier

I pushed fixes CI should pass?

@mikehardy mikehardy merged commit 8cad8b7 into react-native-netinfo:master Jun 28, 2022
@mikehardy mikehardy removed the pending merge A PR that will be merged shortly, waiting for CI or final comment label Jun 28, 2022
github-actions bot pushed a commit that referenced this pull request Jun 28, 2022
@semantic-release-bot
chore(release): 9.3.0 [skip ci]
dbe35c2 
# [9.3.0](v9.2.0...v9.3.0) (2022-06-28)

### Features

* add linkSpeed, rxLinkSpeed, txLinkSpeed info to wifi on android ([#605](#605)) ([8cad8b7](8cad8b7)), closes [#604](#604)
@matt-oakes
Copy link
Collaborator

🎉 This PR is included in version 9.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@wtlyu wtlyu deleted the feature-wifi-linkspeed branch June 29, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehardy mikehardy mikehardy approved these changes

@matt-oakes matt-oakes Awaiting requested review from matt-oakes matt-oakes is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wtlyu @mikehardy @matt-oakes