feat: add parameter useNativeReachability to optionally choose non-native reachability test #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also cc @mikehardy |
mikehardy
approved these changes
Jun 24, 2022
mikehardy
changed the title
|
nicely done - thanks! |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 24, 2022
# [9.1.0](v9.0.0...v9.1.0) (2022-06-24) ### Features * add parameter useNativeReachability to optionally choose non-native reachability test ([#609](#609)) ([9b02cac](9b02cac))
|
🎉 This PR is included in version 9.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
While using the API, the reachability checks for some Android devices, namely Amazon Kindle Fires, weren't entirely reliable. Upon testing a case where I manually pulled the plug on the internet, the
isInternetReachablewould still returntruefor minutes without an update. The non-native implementation for reachability checks for iOS works very well, so I'm proposing a solution where the user can specify a param to utilize the custom reachability checks to bypass this issue (or if for whatever other reason, they want to specify custom reachability parameters).Test Plan
yarn start:androidand built to Amazon Fire Kindle. Accurately reported Network changes