New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for reachabilityMethod to specify GET or HEAD #610
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
certainly seems reasonable, and backwards-compatible makes it easy to release, let's see what CI thinks then, sure :-). Thanks for posting this
formatting -
I believe the targets are in package.json for local verification? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it doesn't just look functional but prettier should agree it is pretty as well...
hahahah thanks @mikehardy!!! Appreciate your help, as always |
# [9.2.0](v9.1.0...v9.2.0) (2022-06-28) ### Features * add support for reachabilityMethod to specify GET or HEAD ([#610](#610)) ([3f5badd](3f5badd))
🎉 This PR is included in version 9.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Overview
Added in support for an optional field in
NetInfoConfiguration
forreachabilityMethod
which accepts eitherHEAD
orGET
. Some API endpoints don't support HEAD requests and will return a 405 instead of a 204.Test Plan
I set my default configuration to
And was able to verify the request was being made as a
GET
request instead ofHEAD
request