fix(mac-catalyst): add check for mac catalyst target to support the platform #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Info.m and ios/RNCConnectionState.m
mikehardy
approved these changes
Oct 2, 2022
mikehardy
added
the
pending merge
mikehardy
removed
the
pending merge
github-actions bot
pushed a commit
that referenced
this pull request
Oct 2, 2022
## [9.3.3](v9.3.2...v9.3.3) (2022-10-02) ### Bug Fixes * **macCatalyst:** add compilation conditionals for macCatalyst ([#629](#629)) ([8e4cace](8e4cace))
|
🎉 This PR is included in version 9.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
There have been some issues and PRs on Mac Catalyst support like #392, #412, and #415, and #415 specifically supposed to have added the support, but I was still getting compilation errors like what @giona69 posted in #392 (comment).
For each
#ifplatform check inios/RNCNetInfo.mandios/RNCConnectionState.m, I also added another condition forTARGET_OS_MACCATALYSTsimilar to what was proposed in #412 and now everything compiles and runs.I have little experience with Objective-C or macOS development, and I have no idea why
CoreTelephonywas not compiling, but the existing implementation withifaddrs.hseems to work perfectly fine for Mac Catalyst.Test Plan
I modified the
node_modules/@react-native-community/netinfo/iossource code under my React Native project with my fixes and it now runs perfectly fine.useNetInfois returning updated information when I disconnect or reconnect to internet.