Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): return netmask of first IPv4 address #634

Merged
merged 1 commit into from Oct 26, 2022
Merged

fix(android): return netmask of first IPv4 address #634

merged 1 commit into from Oct 26, 2022

Conversation

C-Otto
Copy link
Contributor

@C-Otto C-Otto commented Oct 25, 2022

fixes #633

mikehardy
mikehardy approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - I checked all the APIs, no availability issues I can see (API9 appears to be support minimum)

Great fix

@mikehardy mikehardy added the pending merge A PR that will be merged shortly, waiting for CI or final comment label Oct 26, 2022
@mikehardy mikehardy changed the title return netmask of first IPv4 address fix(android): return netmask of first IPv4 address Oct 26, 2022
@mikehardy mikehardy merged commit f740f45 into react-native-netinfo:master Oct 26, 2022
@mikehardy mikehardy removed the pending merge A PR that will be merged shortly, waiting for CI or final comment label Oct 26, 2022
github-actions bot pushed a commit that referenced this pull request Oct 26, 2022
@semantic-release-bot
chore(release): 9.3.6 [skip ci]
52058a1 
## [9.3.6](v9.3.5...v9.3.6) (2022-10-26)

### Bug Fixes

* **android:** return netmask of first IPv4 address ([#634](#634)) ([f740f45](f740f45)), closes [#633](#633)
@matt-oakes
Copy link
Collaborator

🎉 This PR is included in version 9.3.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@C-Otto C-Otto deleted the fix-633-netmask branch October 26, 2022 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehardy mikehardy mikehardy approved these changes

@matt-oakes matt-oakes Awaiting requested review from matt-oakes matt-oakes is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subnet is returned as 255.255.255.255 instead of 255.255.255.0
3 participants
@C-Otto @matt-oakes @mikehardy