fix(android): avoid crash on devices without wifi #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehardy
requested changes
Apr 5, 2023
There was a problem hiding this comment.
Sorry this crashed for you! Interesting edge case, but it makes sense.
I think the way you originally coded the first change will be breaking for people, but there is an easy modification I propose that should be non-breaking and still solve the crash?
What do you think?
android/src/main/java/com/reactnativecommunity/netinfo/ConnectivityReceiver.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/reactnativecommunity/netinfo/ConnectivityReceiver.java
Show resolved
Hide resolved
…ivityReceiver.java Co-authored-by: Mike Hardy <github@mikehardy.net>
mikehardy
approved these changes
Apr 6, 2023
mikehardy
added
the
pending merge
mikehardy
changed the title
mikehardy
changed the title
mikehardy
removed
the
pending merge
github-actions bot
pushed a commit
that referenced
this pull request
Apr 6, 2023
## [9.3.9](v9.3.8...v9.3.9) (2023-04-06) ### Bug Fixes * **android:** avoid crash on devices without wifi ([#662](#662)) ([a519e59](a519e59))
|
🎉 This PR is included in version 9.3.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I recently faced a crash on a device that does not have WiFi and not provide the WiFi system service.
Only thing we use in our app is
const { isConnected } = useNetInfo();So for us it doesn't really matter what kind of connection, if the device does not support WiFi but has some other connectivity it is fine.
This PR will add a null check for mWifiManager so it would not crash anymore.
Test Plan
No test plan from my side, just followed the stacktrace that showed the crash and fixed the issue, also checked other usages of mWifiManager so it would not crash somewhere else.