fix(web): verify window exists before attempting to access navigator
#666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an issue causing an SSR exception if `getCurrentState` is called.
|
@mikehardy given your comment here #655 (comment) I wanted to ping you as @matt-oakes was auto-assigned as the Reviewer when I submitted the PR. Wanted to put it on someone's radar who was still involved in the project. I know you're quite busy so sorry for adding something onto your list! Anyway, it's a pretty straightforward PR IMHO. Happy to update it to something more stylistically appealing to ya'll (e.g. ✌️ |
mikehardy
approved these changes
May 5, 2023
mikehardy
added
the
pending merge
mikehardy
removed
the
pending merge
github-actions bot
pushed a commit
that referenced
this pull request
May 5, 2023
## [9.3.10](v9.3.9...v9.3.10) (2023-05-05) ### Bug Fixes * **web:** verify `window` exists before attempting to access navigator ([#666](#666)) ([60b99f2](60b99f2))
|
🎉 This PR is included in version 9.3.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue causing an SSR exception if
getCurrentStateis called.Overview
As things currently stand, if for any reason you end up calling
getCurrentStateduring SSR you end up getting an exception due tonavigatorbeingundefined.Test Plan
getCurrentStateduring SSR without this change. See you receive an exception.getCurrentStateduring SSR with this change. See you do not receive an exception.