fix: do not crash on android 11 #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikehardy: Any chance you could take a quick look at this? Many thanks 😄 |
|
Friendly ping here to @mikehardy and perhaps @matt-oakes for this PR review :) Appreciate it! Thanks. |
tido64
reviewed
Jun 28, 2023
android/src/main/java/com/reactnativecommunity/netinfo/NetworkCallbackConnectivityReceiver.java
Outdated
Show resolved
Hide resolved
mikehardy
approved these changes
Jun 29, 2023
android/src/main/java/com/reactnativecommunity/netinfo/NetworkCallbackConnectivityReceiver.java
Show resolved
Hide resolved
android/src/main/java/com/reactnativecommunity/netinfo/NetworkCallbackConnectivityReceiver.java
Outdated
Show resolved
Hide resolved
mikehardy
added
the
pending merge
mikehardy
removed
the
pending merge
github-actions bot
pushed a commit
that referenced
this pull request
Jun 29, 2023
## [9.3.11](v9.3.10...v9.3.11) (2023-06-29) ### Bug Fixes * do not crash on android 11 ([#672](#672)) ([bb13143](bb13143))
|
🎉 This PR is included in version 9.3.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We are submitting this PR as part of the errors we are seeing in one of our hostapps in Microsoft on Android. Especially on Android 11, there seems to be a SecurityException thrown if the app is not bound yet while the Activity is created. Google has fixed this issue in vNext, Android 13 and Android 12. However, Android 11 still remains unpatched crashing around 500 times per week.
Test Plan
For the test plan, it is a bit hard to repro due to the timing error. If you have a look at the fix by Chalard Jean at Google here, it involves several manual steps to get into this bad state for the ConnectivityManager.
Issue link
#674