feat: add HTTP headers through reachabilityHeaders param to NetInfoConfiguration #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matt-oakes @mikehardy any idea when you'll have time to look into this PR? |
|
@matt-oakes @mikehardy any updates guys? |
mikehardy
approved these changes
Nov 1, 2023
mikehardy
added
the
pending merge
mikehardy
removed
the
pending merge
github-actions bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
# [9.5.0](v9.4.2...v9.5.0) (2023-11-01) ### Features * add optional reachabilityHeaders param to NetInfoConfiguration ([#673](#673)) ([0cbf067](0cbf067))
|
🎉 This PR is included in version 9.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mikehardy
reviewed
Nov 6, 2023
| @@ -115,6 +115,7 @@ export type NetInfoSubscription = () => void; | |||
| export interface NetInfoConfiguration { | |||
| reachabilityUrl: string; | |||
| reachabilityMethod?: NetInfoMethodType; | |||
| reachabilityHeaders?: HeadersInit; | |||
There was a problem hiding this comment.
Hey @webraptor 👋 - this HeadersInit appears undefined, as noted in #693 - what should it be? Seem like it should be whatever valid internet headers are, perhaps { [index: string]: string; } or similar? What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We've been using react-native-netinfo for quite some time now. We recently needed a change where we can pass along custom headers to the reachability request. This PR adds a new
reachabilityHeadersprop toNetInfoConfigurationso that HTTP headers can be set on the request.Test Plan
Ran the entire test suite & validation the project has, ensured code style matches. We also tested the integration within our project to validate the functionality against our backend which requires custom headers be present in the request.