fix!: cancel _checkInternetReachability request on timeout & cancel via AbortController #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcarrag
force-pushed
the
fix_checkInternetReachability_timeout
branch
from
7766ff1
to
0f71dd9
Compare
jcarrag
changed the title
|
Hi @mikehardy does this look ok to you? If you want tests for this change then I can give them a go |
mikehardy
approved these changes
Nov 1, 2023
|
I am closing an re-opening just to see if that will kick off CI |
mikehardy
added
the
pending merge
eslint behaves differently right now between windows/macOS and ubuntu the CI check is on ubuntu, and some problems are only showing up there
BREAKING CHANGES: netinfo now requires AbortController, node v16 / edge required it will likely not work on internet explorer from this version onwards
|
mikehardy
changed the title
|
Cheers Mike |
mikehardy
pushed a commit
that referenced
this pull request
Nov 1, 2023
…cancel via AbortController (#678) * fix!: cancel _checkInternetReachability request on timeout & cancel Taken from #439 (comment) * style(lint): yarn validate:estlint --fix eslint behaves differently right now between windows/macOS and ubuntu the CI check is on ubuntu, and some problems are only showing up there * fix!: node v16 is now the minimum supported version - AbortController BREAKING CHANGE: netinfo now requires AbortController, node v16 / edge required it will likely not work on internet explorer from this version onwards
github-actions bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
# [10.0.0](v9.5.0...v10.0.0) (2023-11-01) * fix(cancel)!: cancel _checkInternetReachability request on timeout & cancel via AbortController (#678) ([4bfd3e2](4bfd3e2)), closes [#678](#678) [/github.com//issues/439#issue-787487438](https://github.com//github.com/react-native-netinfo/react-native-netinfo/issues/439/issues/issue-787487438) ### BREAKING CHANGES * netinfo now requires AbortController, node v16 / edge required it will likely not work on internet explorer from this version onwards
mikehardy
removed
the
pending merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from #439 (comment)