Fixed Typeerror for addvenetlistner added isWifiEnabled type in NetInfoUnknownState and NetInfoDisconnectedState #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matt-oakes is it already merged, can you please look after this. |
|
I am closing and re-opening just to kick off CI |
mikehardy
added
the
pending merge
mikehardy
removed
the
pending merge
github-actions bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
## [9.4.2](v9.4.1...v9.4.2) (2023-11-01) ### Bug Fixes * **types:** add optional isWifiEnabled boolean to NetInfoUnknownState + NetInfoDisconnectedState ([#680](#680)) ([46c4c71](46c4c71))
|
🎉 This PR is included in version 9.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When using NetInfo.addEventListener was getting
isWifiEnabledin data but was getting typeerror when using it. so addisWifiEnabledasbooleanand optional type in NetInfoUnknownState and NetInfoDisconnectedState.Test Plan
1] Run Yarn test got all my the test cases passed.
2] Run yarn validate:typescript all test case passed without any error.