Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to drop below a Group #695

Open
kushgupta3 opened this issue May 9, 2024 · 2 comments
Open

Not able to drop below a Group #695

kushgupta3 opened this issue May 9, 2024 · 2 comments

Comments

@kushgupta3
Copy link

kushgupta3 commented May 9, 2024

Description

When drag and drop is enabled:-
Case 1: When Combinator between rules is disabled - We are not able to drop Rule/Group below a group at all.
Case 2: When Combinator between rules is enabled - We can drop below the group as there is a combinator present under it but if the group is at last position then we are not able to drop below the group i.e the last position.

Reproduction

Case 1:- Try to drop below the group (it won't work): Try here
Case 2:- Try dropping below the group (it will work) and then move the group to last position then try drooping below it (it won't work): Try here

@jakeboone02
Copy link
Member

This is actually a problem I've struggled a lot with since I started implementing drag-and-drop. It's a hard problem because there's no "active" area at the bottom of a group (other than whatever padding is applied via CSS), so there's no surface over which to hover/drop and trigger an action. Well, at least there's no way to distinguish between the intent to drop a rule below the last rule in a group and the intent to drop a rule below the group itself.

I'll take a look at it again, but any help as far as how to implement this intuitively and with no (or at least minimal) breaking changes would be appreciated.

This wasn't what you were asking for, but an alternative that may be worth looking at is showShiftActions.

@kushgupta3
Copy link
Author

@jakeboone02 Thanks for looking in.
Will let you know if I find any approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants