You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
We're using TailwindCSS to style our website. Just upgraded this component for security reasons and found that lineNumberContainerProps and lineNumberProps were removed. Also, lineProps is not allowing us to pass custom classNames. That makes it impossible for us to use both Tailwind and this component.
Describe the solution you'd like
For lineNumberProps and lineNumberContainerProps either bring them back or maybe create something like lineNumberClassNames and lineNumberContainerClassNames. Happy to discuss what's better.
For lineProps, it seems the offending line is this one. Maybe this can be changed to:
Describe alternatives you've considered
I've considered requiring the Tailwind configuration file from the component but that would couple the component to the config file, making it less reusable. Also considered hard-coding the values I want as inline styles but we'd get duplicated values in the config file and in this component.
Happy to help implementing the solution to this. Thanks for the great work! 🙌
The text was updated successfully, but these errors were encountered:
Good catch! Looks like there was a PR to get rid of lineNumberContainerStyle and lineNumberStyle and replace them with lineNumberContainerProps and lineNumberProps: #229 ... but somehow it was regressed with the 13.0.0 update.
If you've got a bit of time to implement a solution, we'd be grateful.
Is your feature request related to a problem? Please describe.
We're using TailwindCSS to style our website. Just upgraded this component for security reasons and found that
lineNumberContainerProps
andlineNumberProps
were removed. Also,lineProps
is not allowing us to pass custom classNames. That makes it impossible for us to use both Tailwind and this component.You can see more here: https://github.com/asyncapi/website/blob/master/components/editor/CodeBlock.js#L61-L77.
Describe the solution you'd like
For
lineNumberProps
andlineNumberContainerProps
either bring them back or maybe create something likelineNumberClassNames
andlineNumberContainerClassNames
. Happy to discuss what's better.For
lineProps
, it seems the offending line is this one. Maybe this can be changed to:Describe alternatives you've considered
I've considered requiring the Tailwind configuration file from the component but that would couple the component to the config file, making it less reusable. Also considered hard-coding the values I want as inline styles but we'd get duplicated values in the config file and in this component.
Happy to help implementing the solution to this. Thanks for the great work! 🙌
The text was updated successfully, but these errors were encountered: