Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4.0-alpha-01] nested .eslintignore file ignored #47

Open
Edelf opened this issue Apr 30, 2020 · 3 comments
Open

[3.4.0-alpha-01] nested .eslintignore file ignored #47

Edelf opened this issue Apr 30, 2020 · 3 comments

Comments

@Edelf
Copy link

Edelf commented Apr 30, 2020

After upgrading to 3.4.0-alpha-01 I started to have lint errors in serviceWorker.ts even tho the file is listed in the .eslintignore:

Failed to compile.

./packages/apps/my-ts-app/src/serviceWorker.ts
  Line 47:9:  'checkValidServiceWorker' was used before it was defined  @typescript-eslint/no-use-before-define
  Line 59:9:  'registerValidSW' was used before it was defined          @typescript-eslint/no-use-before-define

Search for the keywords to learn more about each error.

/packages/apps/.eslintignore:

**/node_modules/**
**/dist/**
**/storybook-static/**
**/coverage/**
**/build/**
**/.git/**
**/public/**
serviceWorker.ts

The only way for serviceWorker.ts to be ignored is to add it to the .eslintignore at the root:
.eslintignore:

**/node_modules/**
**/dist/**
**/storybook-static/**
**/coverage/**
**/build/**
**/.git/**
**/public/**
!.eslintrc.js
serviceWorker.ts

Steps to reproduce:

  • checkout this repo
  • remove non-TS projects (leaving only components-typescript and apps\app-typescript )
  • yarn install (using 1.19.0)
  • yarn upgrade-interactive --latest (https://i.imgur.com/kxBhULx.png)
  • yarn workspace @project/app-typescript start
@alanrubin
Copy link

True, that happens to me as well after upgrading to 3.4.0-alpha-01

@F1LT3R
Copy link
Collaborator

F1LT3R commented May 6, 2020

I notice you interactive upgrade updates babel-eslint. This may be a 'babel-eslint` issue.

If you downgrade babel-eslint after the interactive upgrade, what happens?

@Edelf
Copy link
Author

Edelf commented May 7, 2020

I didn't select it to update. Only selected ( * ) the @react-workspaces dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants