Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag and Drop example has import issues #376

Open
seanforyou23 opened this issue Sep 13, 2019 · 4 comments
Open

Drag and Drop example has import issues #376

seanforyou23 opened this issue Sep 13, 2019 · 4 comments

Comments

@seanforyou23
Copy link

Hi, I'm getting acquainted with this library for the first time - looks nice! When following the drag and drop example I'm met with an error for one of the imports.

Screen Shot 2019-09-13 at 12 46 47 PM

I noticed this is an import available from reactabular-dnd, but when I try to use that module instead I get the following error.

Screen Shot 2019-09-13 at 12 55 58 PM

I struggle to understand exactly how to tie in the DragDropContext bit, or even really know what it's needed for. Have I overlooked any documentation where this is explained? Otherwise, could you help point me in the right direction? Let me know if you need anything further from me to help diagnose, thx!

@bebraw
Copy link
Member

bebraw commented Sep 16, 2019

Hi,

Can you set up a small standalone example I can run? It sounds like maybe some underlying dependency has changed their API signature somehow which is breaking the module. It's possible we may have to rewrite some code to work with the newest version.

@seanforyou23
Copy link
Author

No problem, try this branch out

https://github.com/seanforyou23/patternfly-react-seed/tree/reactabular

If you clone it, run yarn && yarn start, then you should see a blank screen with the error in the console.

If you open the project in an IDE you'll see this line flagged as error.

Thanks for looking into it!

@souuu
Copy link

souuu commented Oct 1, 2019

Any solution for this ?
react-dnd said that they do no longer use DragDropContext. It was removed since version 9.

How can we solve this ?

@lmeikle
Copy link
Contributor

lmeikle commented Oct 4, 2019

@souuu I have added the below to my projects package.json to ensure we do not use version 9. You could try that as a work around for now?

"resolutions": {
"react-dnd": "8.0.2"
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants