Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle-SymbolicName changed from 1.0.3 to 1.0.4 #540

Open
Lana11s opened this issue Jul 4, 2022 · 2 comments
Open

Bundle-SymbolicName changed from 1.0.3 to 1.0.4 #540

Lana11s opened this issue Jul 4, 2022 · 2 comments

Comments

@Lana11s
Copy link

Lana11s commented Jul 4, 2022

Hello,

in the manifest file, the Bundle-SymbolicName has changed from org.reactivestreams.reactive-streams to reactive-streams.
Probably happend because of a newer version of AdoptOpenJDK?

Old manifest:

Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Created-By: 11.0.3 (AdoptOpenJDK)
Tool: Bnd-3.4.0.201707252008
Bnd-LastModified: 1566549673167
Export-Package: org.reactivestreams;version="1.0.3"
Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.6))"
Bundle-DocURL: http://reactive-streams.org
Bundle-Vendor: Reactive Streams SIG
Bundle-Description: Reactive Streams API
Bundle-Name: reactive-streams
Bundle-Version: 1.0.3
Automatic-Module-Name: org.reactivestreams
Bundle-SymbolicName: org.reactivestreams.reactive-streams

New manifest:

Manifest-Version: 1.0
Automatic-Module-Name: org.reactivestreams
Bnd-LastModified: 1653251974168
Bundle-Description: Reactive Streams API
Bundle-DocURL: http://reactive-streams.org
Bundle-ManifestVersion: 2
Bundle-Name: reactive-streams-jvm
Bundle-SymbolicName: reactive-streams
Bundle-Vendor: Reactive Streams SIG
Bundle-Version: 1.0.4
Created-By: 11.0.11 (AdoptOpenJDK)
Export-Package: org.reactivestreams;version="1.0.4"
Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.6))"
Tool: Bnd-4.3.1.201911131708
@viktorklang
Copy link
Contributor

@Lana11s Hi,

Not sure why that changed, could be due to a change in the BND plugin between 3.4 and 4.3?

This is what's set on a per-artifact basis: https://github.com/reactive-streams/reactive-streams-jvm/blob/master/api/build.gradle#L22

@akarnokd
Copy link
Contributor

akarnokd commented Jul 5, 2022

Not sure about BND, but we had to make it explicit a while back too:

https://github.com/ReactiveX/RxJava/blob/3.x/build.gradle#L100

viktorklang added a commit that referenced this issue Jul 5, 2022
…D plugin

Signed-off-by: Viktor Klang <viktor.klang@gmail.com>
rkuhn added a commit that referenced this issue Aug 5, 2023
…olicName-√

Fixing #540 by manually overriding the Bundle-SymbolicName for the BN…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants