housekeeping:Seal List Internals #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwcullop
added a commit
to dwcullop/DynamicData
that referenced
this pull request
Dec 16, 2023
…n moved to reactivemarbles#796 This reverts commit 315f013.
glennawatson
approved these changes
Dec 16, 2023
dwcullop
added a commit
that referenced
this pull request
Dec 16, 2023
#790) * First drop of MergeManyChangeSets for List to Cache * Fix test data * Improved test * Unit Testing a thread issue * More progress on stress tests * All Unit Tests Pass! * Stress Tester refactor * Finalization - Code Cleanup - Move Synchronization call - Remove extra Cache / List that isn't needed - Add EqualityComparer to List-to-List version * API Fixes * Fixed Unit Tests * Fix Build, enable test SourceErrorsImmediately_SubscriptionReceivesError is now re-enabled I ran on a loop test and passed every time * So close! * Switch to bools * Code Cleanup * Revert Change that may be the problem * Revert debugging helper * Update Stress Test * Update List internal classes to be sealed * Enable other Skipped tests, no issues seem to be present * Convert to pure Observable no Sleep or Delay * Improved Faker use of statics * Simplify and add OnError notifications * Revert "Update List internal classes to be sealed" because it has been moved to #796 This reverts commit 315f013. * Add sealed to a few classes * Finalize Test Code --------- Co-authored-by: Chris Pulman <chris.pulman@yahoo.com>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving the commit that sealed the List internal classes into their own PR. Thank you @ChrisPulman for making these changes.