Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Stress Tests for List-to-List MergeManyChangeSets #800

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Feature: Stress Tests for List-to-List MergeManyChangeSets #800

merged 4 commits into from
Dec 18, 2023

Conversation

dwcullop
Copy link
Member

@dwcullop dwcullop commented Dec 18, 2023 •
edited

Description

  • Migrates the stress tests from the Cache-List version of MergeManyChangeSets test fixture to the List-List version, but consolidates them so they don't take so long to run
  • Applies improvements made to the Cache-List version as well to keep them in sync
  • Aligns implementation of List-List with the Cache-List version (removes use of intermediate SourceList)
  • Fixes minor bug in the List-List version where it wasn't passing the IEqualityComparer implementation to the internal class

@dwcullop dwcullop enabled auto-merge (squash) December 18, 2023 01:52
@dwcullop dwcullop self-assigned this Dec 18, 2023
@dwcullop
Copy link
Member Author

@RolandPheasant This one is ready I think.

RolandPheasant
RolandPheasant approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@RolandPheasant RolandPheasant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, I am happy to leave this to your discretion.

Also this is all test code, and besides we can release when we are ready so zero risk.

@dwcullop dwcullop merged commit 13bd8c6 into reactivemarbles:main Dec 18, 2023
1 check passed
@dwcullop dwcullop deleted the feature/list-list-mergemanychangesets-stress branch December 20, 2023 01:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JakenVeina JakenVeina JakenVeina left review comments

@RolandPheasant RolandPheasant RolandPheasant approved these changes

Assignees

@dwcullop dwcullop

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dwcullop @RolandPheasant @JakenVeina