Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Multithreaded Stress Test for List-to-Cache MergeManyChangeSets #806

Conversation

dwcullop
Copy link
Member

@dwcullop dwcullop commented Dec 20, 2023

Description

Adds a multithreaded stress test to the list-to-change version of the MergeManyChangeSet operator. Initially, this test would fail with a deadlock, incorrect results, or an exception. Therefore, this PR also includes the changes to the operator implementation in order to make it thread safe.

Other Changes

  • Improvements to make the unit tests more deterministic

@dwcullop dwcullop self-assigned this Dec 20, 2023
@dwcullop dwcullop enabled auto-merge (squash) December 20, 2023 01:56
@JakenVeina
Copy link
Collaborator

Sum'n's breakin'.

@dwcullop
Copy link
Member Author

Sum'n's breakin'.

Yeah. I didn't think I impacted any of the existing tests, but I guess I did. I'll investigate.

@dwcullop dwcullop enabled auto-merge (squash) December 21, 2023 21:40
@dwcullop dwcullop merged commit 4ffeec0 into reactivemarbles:main Dec 21, 2023
1 check passed
@dwcullop dwcullop deleted the feature/list-cache-mergemanychangesets-stress branch December 22, 2023 22:47
Copy link

github-actions bot commented Jan 6, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants