Feature: TransformMany Async #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ullop/DynamicData into feature/transform-many-async
…is based on MMCS but with several changes
Extracted logic for creating the changesets from the Task result types. Improved comments.
RolandPheasant
approved these changes
Jan 19, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements
TransformManyAsyncandTransformManySafeAsyncfor #461.Creates a new operator implementation that is based on the implementation of
MergeManyChangeSetsbut allows the child selector to be Async, allows for an optional error handler, and does "best effort" to try to minimize the number of changesets.TransformManywill emit a single changeset with all of the added child values for each parent changeset. This is not ideal for the async version because each parent value added creates an async call. This would mean that no changeset could be emitted until all of the async operations have completed.As a compromise, the new operator will use an atomic counter to determine how many async operations have completed (but not been processed) and will not emit a changeset until all completed operations have been processed. This changeset will be emitted even if there are async operations pending because there is no way to tell how they will take.
This should be a good balance between timely changesets and fewer changesets.