Feature: SuspendNotifications Methods for SourceCache / IntermediateCache #852
+611
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwcullop
changed the title
dwcullop
changed the title
JakenVeina
requested changes
Feb 20, 2024
JakenVeina
approved these changes
Feb 20, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
INotifyCollectionChangedSuspenderinterface toIntermediateCacheandSourceCachewhich addsSuspendNotificationsandSuspendCountmethods which will block either the ChangeSet observable or the CountChanged observable (respectively) until the IDisposable that the method returns is Disposed.CountChangedwill always emit the current count on subscription, but no further changes will be emitted until the suspension is complete, when it will emit the updated count (if it has changed).Connectwill not emit any ChangeSets upon subscription when suspended. When the suspension is complete, it will emit a single changeset with the most recent contents and all a changeset for all future changes.For subscriptions created BEFORE the suspension, no more changesets will be emitted until the suspension is complete, and then a single changeset, with ALL the changes that have been made will be emitted at once.
Both suspensions can be invoked multiple times and all IDisposables have to be Disposed before messages will resume.