Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Move DynamicDataOptions #864

Merged
merged 5 commits into from
Mar 3, 2024

Conversation

dwcullop
Copy link
Member

Description

  • Moved DynamicDataOptions to its own file
  • Moved DynamicDataOptions to the top-level namespace

@dwcullop dwcullop added the Housekeeping Pull requests for minor code maintenance issues label Feb 20, 2024
@dwcullop dwcullop self-assigned this Feb 20, 2024
@dwcullop dwcullop enabled auto-merge (squash) February 20, 2024 19:40
@dwcullop
Copy link
Member Author

dwcullop commented Feb 20, 2024

@RolandPheasant If this is what you had in mind, then accept it at your leisure. Or save it for later if you're not ready to make the breaking change.

Later we can discuss if we want to put a read/write IScheduler property on it and then have GlobalConfig.DefaultScheduler forward to that value (or update all the instances to point to it).

@dwcullop dwcullop merged commit 7c150e6 into reactivemarbles:main Mar 3, 2024
1 check passed
@RolandPheasant
Copy link
Collaborator

@glennawatson / @ChrisPulman this is a minor break which changes the namespace of an object that was introduced in the last release. It is correcting an error, so although technically a breaking change I do not intend to bump the major version

@glennawatson
Copy link
Member

Likely doesn't impact us then. The rxui integration uses methods that have existed for quite some time.

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Housekeeping Pull requests for minor code maintenance issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants