refactor: test for side effects, and remove existing ones (#4769) (#4953

)

* test: add test for side-effects

* refactor: remove toplevel property access

.circleci/config.yml

@@ -50,6 +50,7 @@ jobs:
     steps:
       - attach_workspace: *attach_options
       - run: npm test
+      - run: npm run test:side-effects
 
   dtslint:
     <<: *defaults

.eslintignore

@@ -0,0 +1 @@
+integration/side-effects/snapshots/

.gitignore

@@ -24,3 +24,7 @@ spec-build/
 # Misc
 npm-debug.log
 .DS_STORE
+
+# The check-side-effects package generates and deletes this file.
+# If the process is killed, it will be left behind.
+check-side-effects.tmp-input.js

integration/side-effects/README.md

@@ -0,0 +1,9 @@
+This test checks if the side effects for loading RxJs packages have changed using <https://github.com/filipesilva/check-side-effects>.
+
+Running `npm test:side-effects` will check all ES modules listed in `side-effects.json`.
+
+Running `npm test:side-effects:update` will update any changed side effects.
+
+To add a new ES module to this test, add a new entry in `side-effects.json`.
+
+Usually the ESM and FESM should have the same output, but retained objects that were renamed during the flattening step will leave behind a different name.

integration/side-effects/side-effects.json

@@ -0,0 +1,52 @@
+{
+  "tests": [
+    {
+      "esModules": "../../dist/esm5/index.js",
+      "expectedOutput": "./snapshots/esm5/index.js"
+    },
+    {
+      "esModules": "../../dist/esm2015/index.js",
+      "expectedOutput": "./snapshots/esm2015/index.js"
+    },
+    {
+      "esModules": "../../dist/esm5/ajax/index.js",
+      "expectedOutput": "./snapshots/esm5/ajax.js"
+    },
+    {
+      "esModules": "../../dist/esm2015/ajax/index.js",
+      "expectedOutput": "./snapshots/esm2015/ajax.js"
+    },
+    {
+      "esModules": "../../dist/esm5/fetch/index.js",
+      "expectedOutput": "./snapshots/esm5/fetch.js"
+    },
+    {
+      "esModules": "../../dist/esm2015/fetch/index.js",
+      "expectedOutput": "./snapshots/esm2015/fetch.js"
+    },
+    {
+      "esModules": "../../dist/esm5/operators/index.js",
+      "expectedOutput": "./snapshots/esm5/operators.js"
+    },
+    {
+      "esModules": "../../dist/esm2015/operators/index.js",
+      "expectedOutput": "./snapshots/esm2015/operators.js"
+    },
+    {
+      "esModules": "../../dist/esm5/testing/index.js",
+      "expectedOutput": "./snapshots/esm5/testing.js"
+    },
+    {
+      "esModules": "../../dist/esm2015/testing/index.js",
+      "expectedOutput": "./snapshots/esm2015/testing.js"
+    },
+    {
+      "esModules": "../../dist/esm5/webSocket/index.js",
+      "expectedOutput": "./snapshots/esm5/websocket.js"
+    },
+    {
+      "esModules": "../../dist/esm2015/webSocket/index.js",
+      "expectedOutput": "./snapshots/esm2015/websocket.js"
+    }
+  ]
+}

integration/side-effects/snapshots/esm2015/ajax.js

@@ -0,0 +1 @@
+

integration/side-effects/snapshots/esm2015/fetch.js

@@ -0,0 +1 @@
+

integration/side-effects/snapshots/esm2015/index.js

@@ -0,0 +1,7 @@
+var NotificationKind;
+
+(function(NotificationKind) {
+    NotificationKind["NEXT"] = "N";
+    NotificationKind["ERROR"] = "E";
+    NotificationKind["COMPLETE"] = "C";
+})(NotificationKind || (NotificationKind = {}));

integration/side-effects/snapshots/esm2015/operators.js

@@ -0,0 +1,7 @@
+var NotificationKind;
+
+(function(NotificationKind) {
+    NotificationKind["NEXT"] = "N";
+    NotificationKind["ERROR"] = "E";
+    NotificationKind["COMPLETE"] = "C";
+})(NotificationKind || (NotificationKind = {}));

integration/side-effects/snapshots/esm2015/testing.js

@@ -0,0 +1,7 @@
+var NotificationKind;
+
+(function(NotificationKind) {
+    NotificationKind["NEXT"] = "N";
+    NotificationKind["ERROR"] = "E";
+    NotificationKind["COMPLETE"] = "C";
+})(NotificationKind || (NotificationKind = {}));

integration/side-effects/snapshots/esm2015/websocket.js

@@ -0,0 +1,7 @@
+var NotificationKind;
+
+(function(NotificationKind) {
+    NotificationKind["NEXT"] = "N";
+    NotificationKind["ERROR"] = "E";
+    NotificationKind["COMPLETE"] = "C";
+})(NotificationKind || (NotificationKind = {}));

integration/side-effects/snapshots/esm5/ajax.js

@@ -0,0 +1 @@
+import "tslib";

integration/side-effects/snapshots/esm5/fetch.js

@@ -0,0 +1 @@
+import "tslib";

integration/side-effects/snapshots/esm5/index.js

@@ -0,0 +1 @@
+import "tslib";

integration/side-effects/snapshots/esm5/operators.js

@@ -0,0 +1 @@
+import "tslib";

integration/side-effects/snapshots/esm5/testing.js

@@ -0,0 +1 @@
+import "tslib";

integration/side-effects/snapshots/esm5/websocket.js

@@ -0,0 +1 @@
+import "tslib";