Skip to content

Commit ff5a748

Browse files
authoredAug 14, 2021
fix: scheduling with Rx-provided schedulers will no longer leak action references (#6562)
* fix: scheduling with Rx-provided schedulers will no longer leak action references Resolves #6561 * refactor: Remove circular dependencies and redundant code * chore: update api_guardian files
1 parent 5d0e41e commit ff5a748

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+318
-345
lines changed
 

‎api_guard/dist/types/index.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ export declare function forkJoin<T extends Record<string, ObservableInput<any>>>
251251
}>;
252252

253253
export declare function from<O extends ObservableInput<any>>(input: O): Observable<ObservedValueOf<O>>;
254-
export declare function from<O extends ObservableInput<any>>(input: O, scheduler: SchedulerLike): Observable<ObservedValueOf<O>>;
254+
export declare function from<O extends ObservableInput<any>>(input: O, scheduler: SchedulerLike | undefined): Observable<ObservedValueOf<O>>;
255255

256256
export declare function fromEvent<T>(target: HasEventTargetAddRemove<T> | ArrayLike<HasEventTargetAddRemove<T>>, eventName: string): Observable<T>;
257257
export declare function fromEvent<T, R>(target: HasEventTargetAddRemove<T> | ArrayLike<HasEventTargetAddRemove<T>>, eventName: string, resultSelector: (event: T) => R): Observable<R>;

‎src/internal/observable/combineLatest.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import { popResultSelector, popScheduler } from '../util/args';
1010
import { createObject } from '../util/createObject';
1111
import { OperatorSubscriber } from '../operators/OperatorSubscriber';
1212
import { AnyCatcher } from '../AnyCatcher';
13+
import { executeSchedule } from '../util/executeSchedule';
1314

1415
// combineLatest(any)
1516
// We put this first because we need to catch cases where the user has supplied
@@ -293,7 +294,7 @@ export function combineLatestInit(
293294
*/
294295
function maybeSchedule(scheduler: SchedulerLike | undefined, execute: () => void, subscription: Subscription) {
295296
if (scheduler) {
296-
subscription.add(scheduler.schedule(execute));
297+
executeSchedule(subscription, scheduler, execute);
297298
} else {
298299
execute();
299300
}

0 commit comments

Comments
 (0)
Please sign in to comment.