Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testscheduler): type arguments to Observable creation functions #3928

Merged
merged 1 commit into from
Jul 25, 2018

Conversation

felixfbecker
Copy link
Contributor

Description:
Adds types to the arguments of TestScheduler createHot/ColdObservable to allow type inference.

Related issue (if exists):
Fixes #3921

@felixfbecker
Copy link
Contributor Author

Build failure is coming from master.

Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cartant
Copy link
Collaborator

cartant commented Jul 17, 2018

@felixfbecker Yeah, the CI build is failing because of a linting error. See #3929.

@benlesh benlesh merged commit 0e30ef1 into ReactiveX:master Jul 25, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants