Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(umd): export fetch namespace #4738

Merged
merged 1 commit into from May 2, 2019
Merged

fix(umd): export fetch namespace #4738

merged 1 commit into from May 2, 2019

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Apr 26, 2019

Oops. I forgot to make sure this was available in the umd bundle (which people use for playground apps)

@benlesh benlesh requested a review from cartant April 26, 2019 15:10
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8420

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 96.659%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/internal/umd.ts 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/internal/OuterSubscriber.ts 1 50.0%
Totals Coverage Status
Change from base Build 8414: -0.2%
Covered Lines: 5208
Relevant Lines: 5388
💛 - Coveralls

@benlesh benlesh merged commit 7926122 into ReactiveX:master May 2, 2019
BioPhoton pushed a commit to BioPhoton/rxjs that referenced this pull request May 15, 2019
@benlesh @BioPhoton
fix(umd): export fetch namespace (ReactiveX#4738)
8ddb09c
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cartant cartant cartant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benlesh @coveralls @cartant