fix(fromFetch): don't abort if fetch resolves #4742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8424
💛 - Coveralls |
benlesh
approved these changes
May 2, 2019
|
Thanks for picking this one up @cartant! |
|
Just ran into this issue, any chance for a release? |
BioPhoton
pushed a commit
to BioPhoton/rxjs
that referenced
this pull request
May 15, 2019
* test(fetch): test expectations after complete * fix(fromFetch): don't abort if fetch resolves Closes ReactiveX#4739
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR rearranges an existing test so that the expectations are performed after the complete - and subsequent unsubscribe - are finished. The rearranged test fails.
It also adds a flag to the
fromFetchimplementation so thatabortis not called in the teardown if the promise returned byfetchhas resolved.This fixes the problem, but it also highlights a problem with the implementation: streamed data obtained using
fromFetchcannot be aborted, as theAbortControllerpassed to fetch also aborts the promises returned fromtextandjson, etc.Related issue (if exists): #4739