Test for side effects, and remove existing ones #4769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
commented
May 10, 2019
| NotificationKind["NEXT"] = "N"; | ||
| NotificationKind["ERROR"] = "E"; | ||
| NotificationKind["COMPLETE"] = "C"; | ||
| })(NotificationKind || (NotificationKind = {})); |
There was a problem hiding this comment.
This code is retained because of how TS transpiles enums. Newer versions of TS don't suffer from this.
filipesilva
commented
May 10, 2019
| @@ -0,0 +1,622 @@ | |||
| import { __extends } from "tslib"; | |||
There was a problem hiding this comment.
This module in particular retains a lot of code.
filipesilva
commented
May 10, 2019
| @@ -0,0 +1,9 @@ | |||
| This test checks if the side effects for loading Angular packages have changed using <https://github.com/filipesilva/check-side-effects>. | |||
|
|
|||
There was a problem hiding this comment.
This file explains how to use the side effect test.
filipesilva
commented
May 10, 2019
| @@ -1,584 +1,3 @@ | |||
| function isFunction(x) { | |||
There was a problem hiding this comment.
All this retained code is now gone.
Generated by 🚫 dangerJS |
filipesilva
force-pushed
the
side-effects
branch
3 times, most recently
from
258a055
to
9fe10d3
Compare
14 tasks
benlesh
approved these changes
May 15, 2019
benlesh
approved these changes
May 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds tests for side effects to the RxJS ESM bundles.
It also makes use a tslint rule to identify a known side-effect producing pattern, allowing us to refactor that away and remove existing side effects.
Related issue (if exists):
This PR is part of the effort in Angular to remove side effects (angular/angular#29329).