fix(race): ignore latter sources after first complete or error #4809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Because subscribing to Observables can have side effects, this will be a breaking change, and we can't land it in 6.x. However we could land it in master. |
benlesh
approved these changes
Jun 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The implementation of
raceignores latter sources if an earlier source emits anextnotification. This PR fixes the implementation so that latter sources are also ignored if an earlier source wins the race by emitting either acompleteor anerrornotification.This PR adds failing tests that are fixed by the change.
For more information, see the related issue - it contains code snippets that highlight the inconsistent behaviour.
Related issue (if exists): #4808