Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TestScheduler): expose frameTimeFactor property #4977

Merged
merged 1 commit into from Sep 3, 2019

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Aug 22, 2019

  • Makes frameTimeFactor public so people do not have to cast in TypeScript
  • Deprecates frameTimeFactor on VirtualTimeScheduler as it is not used in that class, it
    is really only intended to be used for TestScheduler marble diagrams
  • Deprecates index on VirtualTimeScheduler because it is a leaked implementation detail
  • Adds documentation

- Makes `frameTimeFactor` public so people do not have to cast in TypeScript
- Deprecates `frameTimeFactor` on `VirtualTimeScheduler` as it is not used in that class, it
is really only intended to be used for `TestScheduler` marble diagrams
- Deprecates `index` on `VirtualTimeScheduler` because it is a leaked implementation detail
- Adds documentation
@benlesh
Copy link
Member Author

benlesh commented Aug 22, 2019

cc @kolodny

Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benlesh benlesh merged commit 8c32ed0 into ReactiveX:master Sep 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants