Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not reference DOM-related imports #6305

Merged

Conversation

cartant
Copy link
Collaborator

@cartant cartant commented Apr 30, 2021

Description:

This PR removes all DOM-related imports from the references that were added to help VS Code choose the correct import locations for its automatic imports feature.

I've confirmed - using https://github.com/OliverJAsh/rxjs-v7-no-dom-lib-test - that this resolves the problem.

Related issue (if exists): #6297

@cartant cartant requested a review from benlesh April 30, 2021 22:52
@cartant
Copy link
Collaborator Author

cartant commented May 1, 2021

Also, the no-internal ESLint rule now has a fixer.

@benlesh benlesh merged commit b24818e into ReactiveX:master May 4, 2021
@cartant cartant deleted the cartant/remove-dom-vs-code-references branch May 15, 2021 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants