fix(Subscription): null _parentage on unsubscribe #6352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartant
commented
May 4, 2021
Comment on lines
+213
to
+224
| // When d is added to the subscriptions, it's added as a teardown. The | ||
| // length is 1 because the teardowns passed to the ctors are stored in a | ||
| // separate property. | ||
| expect((a as any)._teardowns).to.have.length(1); | ||
| expect((b as any)._teardowns).to.have.length(1); | ||
| expect((c as any)._teardowns).to.have.length(1); | ||
| d.unsubscribe(); | ||
| // When d is unsubscribed, it should remove itself from each of its | ||
| // parents. | ||
| expect((a as any)._teardowns).to.have.length(0); | ||
| expect((b as any)._teardowns).to.have.length(0); | ||
| expect((c as any)._teardowns).to.have.length(0); |
There was a problem hiding this comment.
I could re-write this test as a memory leak test - using FinalizationRegistry instead of the private _teardown property - but IDK. It's fairly straightforward ATM.
benlesh
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixed the bug reported in #6351 by nulling
this._parentagebefore the array is iterated. This was an oversight. It should have been nulled as isthis._teardowns, immediately after it is destructured:rxjs/src/internal/Subscription.ts
Lines 76 to 78 in 7b30546
If
this._parentageis not nulled, it's mutated as it's iterated and parents can be left holding onto child subscriptions that have been closed.The PR also adds - in a separate commit - an
ifstatement around the handling of_parentage, so that the implementation is more like what's done with_teardowns. If there's some reason for not using theifstatement, we can just revert that commit.Related issue (if exists): #6351