feat(Subject): add isObserved() api #6405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlesh
requested changes
May 17, 2021
|
I'm generally in favor of this addition. However, it requires core team agreement. |
backbone87
reviewed
May 18, 2021
|
Notes from core team meeting: Approved, but it should be a readonly property |
benlesh
approved these changes
May 21, 2021
|
@bbarry thanks for this important contribution! It's now out in version 7.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds an api
subject.isObserved()to handle the common use case of the deprecatedsubject.observersmemberRelates to: #5967