fix(debounceTime): unschedule dangling task on unsubscribe before complete #6464
+24
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Since
debounceTime
is not based ondebounce
anymore (#6049), the "notifier subscription" is not managed within the parent subscription anymore, but scheduled "raw". We need to make sure we dont leave dangling tasks behind.I am not sure how to test this.
edit: this also prevents stopped notifications, if the source errors, because that could also leave dangling tasks behind