feat: operators are all exported at the top level, from "rxjs". #6488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlesh
commented
Jun 21, 2021
api_guard/dist/types/index.d.ts
Outdated
| @@ -249,7 +411,7 @@ export interface ObjectUnsubscribedError extends Error { | |||
|
|
|||
| export declare const ObjectUnsubscribedError: ObjectUnsubscribedErrorCtor; | |||
|
|
|||
| export declare const observable: string | symbol; | |||
There was a problem hiding this comment.
I have no idea why this keeps happening. :\
There was a problem hiding this comment.
Apparently it's TS 4.3 inferring the type locally. I'll fix that here too.
cartant
approved these changes
Jun 23, 2021
cailloumajor
added a commit
to cailloumajor/line-supervision-frontend
that referenced
this pull request
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only moves the operators to the top level. Other things like
ajax,webSocket,testing, andfromFetchall require more debate.Related #6242
(Ironically, this will cause tools like Bundlephobia to be like "Whoa! This is bigger!" because they excluded the "deep" imports we had, like
rxjs/operators)