fix(AsyncSubject): properly emits values during reentrant subscriptions #6522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlesh
commented
Jul 14, 2021
| @@ -211,7 +211,7 @@ describe('AsyncSubject', () => { | |||
| expect(calls).to.equal(1); | |||
| }); | |||
|
|
|||
| it('should not be reentrant via next', () => { | |||
| it('should not be reentrant via next', () => { | |||
There was a problem hiding this comment.
We need to get prettier going on this file. This was just moving a space that was bothering me. haha.
benlesh
commented
Jul 14, 2021
| if (hasError) { | ||
| subscriber.error(thrownError); | ||
| } else if (isStopped) { | ||
| } else if (isStopped || _isComplete) { |
There was a problem hiding this comment.
Basically, there's a temporal space where we're _isComplete, but not isStopped while we're nexting to consumers in our complete() method. If someone subscribes during that, we end up hitting this code, and if we're only checking isStopped it's not "stopped" yet, so we didn't notify the consumer.
cartant
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6520