Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange output from React-PropTypes-to-prop-types #306

Closed
kylemh opened this issue Feb 18, 2022 · 5 comments
Closed

Strange output from React-PropTypes-to-prop-types #306

kylemh opened this issue Feb 18, 2022 · 5 comments

Comments

@kylemh
Copy link
Contributor

kylemh commented Feb 18, 2022

I'm usually more descriptive about my issues, but not much I can really say! I ran npx react-codemod React-PropTypes-to-prop-types ./src and basically my machine bricks and starts spitting out some fun ASCII art 馃槀

Screen Shot 2022-02-18 at 3 29 54 PM

I'm using the latest version of MacOS on an M1 MacBook Pro. I'm using Node v14 and npm@7.24.2

@sy19971224
Copy link

Did you solve this problem please?

@kylemh
Copy link
Contributor Author

kylemh commented Mar 17, 2022

Yes! I figured out the problem. This dep uses jscodeshift which uses colors.js and that package was deliberately sabotaged: Marak/colors.js#285.

If you force the resolution of colors.js to be a lower version, you should be able to work.

@kylemh
Copy link
Contributor Author

kylemh commented Jan 4, 2024

Resolved #316

@kylemh kylemh closed this as not planned Won't fix, can't repro, duplicate, stale Jan 4, 2024
@kylemh kylemh reopened this Jan 4, 2024
@kylemh kylemh closed this as completed Jan 4, 2024
@gaearon
Copy link
Member

gaearon commented Jan 4, 2024

Can you verify the fix actually worked?

@kylemh
Copy link
Contributor Author

kylemh commented Jan 4, 2024

Verified :)

source: trust me bro (unless you want a screenshot, but I just ran 2 codemods from 5.4.4 with no issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants