Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace focus trap with inert #1011

Open
OliverJAsh opened this issue Mar 29, 2023 · 1 comment
Open

Replace focus trap with inert #1011

OliverJAsh opened this issue Mar 29, 2023 · 1 comment
Labels
accessibility browser api combining libraries dependencies discussion easy feature good first issue

Comments

@OliverJAsh
Copy link
Contributor

OliverJAsh commented Mar 29, 2023 •
edited

Now that browsers have good support for inert, could we consider replacing the custom focus trap logic with this?

Alternatively, we could use the dialog element so we get this behaviour for free.
@diasbruno
Copy link
Collaborator

diasbruno commented Apr 8, 2023 •
edited

I'll be more conservative with this changes that relies on the browser.
I mean, people that uses the browser are ok, but projects that links with different versions of webviews can be affected.
I'm in favor of delegating the trap logic to a library. The problem is: which library?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility browser api combining libraries dependencies discussion easy feature good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@diasbruno @OliverJAsh