New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Initial Docs Experience #6410
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Philosophy" page is a bit too 'inside baseball' for an effective landing page.
timdorr
approved these changes
Oct 22, 2018
pshrmn
approved these changes
Oct 22, 2018
Thanks for the PR, @justsml! This looks great. I'll deploy it now. |
Should deploy as soon as https://travis-ci.org/ReactTraining/react-router/builds/445992237 is finished 馃憤 |
That's great news @mjackson!!! |
Thank you for your contributions to the docs, @justsml :) A lot of people are going to benefit from the improvements you're making. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi y'all, thanks to everyone for all the work that's gone into this library!!! 馃憤
Here's a summary of my progress so far:
RE: #6409