Added RefObject as valid Link innerRef #6567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timdorr
approved these changes
Jan 31, 2019
|
Seems like a no brainer to me. Thanks for the docs and test! |
|
@timdorr 👋 Is there an ETA on when this fix will be released? |
|
@danhilltech Oof, yeah, |
|
Ah thanks! Sorry, I removed my original as it realized it wasn't a super helpful report. Will try and polyfill now, thanks! |
|
I added a polyfill in #6607. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
React.createRef()with theinnerRefprop of aLink, a false positive prop-types error appears. But it works perfectly.This PR adds the shape of a
RefObject(name forReact.createRef()return type) as a valid prop type forLink'sinnerRef.