perf: don't reflow when there's no class to add

Avoid an unnecessary reflow in the CSSTransition component if the class name is falsy.
reactjs · Jun 13, 2018 · d7b898d · d7b898d
1 parent 84af1ee
commit d7b898d
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/CSSTransition.js b/src/CSSTransition.js
@@ -210,10 +210,12 @@ class CSSTransition extends React.Component {
   reflowAndAddClass(node, className) {
     // This is for to force a repaint,
     // which is necessary in order to transition styles when adding a class name.
-    /* eslint-disable no-unused-expressions */
-    node && node.scrollTop;
-    /* eslint-enable no-unused-expressions */
-    addClass(node, className);
+    if (className) {
+      /* eslint-disable no-unused-expressions */
+      node && node.scrollTop;
+      /* eslint-enable no-unused-expressions */
+      addClass(node, className);
+    }
   }
 
   render() {