Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be separate css class added when state transitions to 'entered' #283

Closed
rmacqueen opened this issue Jan 29, 2018 · 1 comment
Closed

Comments

@rmacqueen
Copy link

For CSSTransitions, right now the library adds the class example-enter and then, in the next tick, example-enter-active. However it doesn't then add any additional class when the transition completes. What this means is that the element being transitioned has the same CSS in the full entered state as it does in the full exited state, which doesn't really make sense. For example, if fading in a component, I want the full exited state to have opacity 0, and the full entered state to have opacity 1. There is no way to do this using the CSSTransition component (though you can achieve it using the lower-level Transition component).
Ideally it would add something like example-entered once in the entered state.

@taion
Copy link
Member

taion commented Jan 29, 2018

This was resolved in #269.

@taion taion closed this as completed Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants