Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Include non-minified (development) version in /dist #64

Closed
virgofx opened this issue May 27, 2017 · 1 comment
Closed

[Feature] Include non-minified (development) version in /dist #64

virgofx opened this issue May 27, 2017 · 1 comment

Comments

@virgofx
Copy link
Contributor

virgofx commented May 27, 2017

Currently, releases in the /dist folder contain only the production/minified version.

It would be very useful for those who organize peer dependencies and include them externally (instead of bundling everything together) to have pathways for local development and production. Specifically, being able to use project build tools to include the distribution of React-transition-group in dev mode alongside the current dev React setup.

When using the minified /dist version in combination with the development React suite, errors result:

react.js:3287 Warning: Failed prop type: Minified exception occurred; use the non-minified dev environment for the full error message and additional helpful warnings.
    in CSSTransitionGroup (created by AppComponent)

Using production react-transition-group with production react suite results in no errors.

So again, when building /dist it would be nice to include 2 files:

  • react-transition-group.js - Development/un-minified
  • react-transition-group.min.js - Production/minified
virgofx added a commit to virgofx/react-transition-group that referenced this issue May 29, 2017
updated Readme to include CDN/External information.
jquense pushed a commit that referenced this issue May 29, 2017
* Incorporated development + production builds into /dist (#64) and
updated Readme to include CDN/External information.

* Dropping references to Webpack specific build configurations in Readme
and adding clarity for CDN/external.
@virgofx
Copy link
Contributor Author

virgofx commented May 31, 2017

Fixed by PR #66 , will be available next release.

@virgofx virgofx closed this as completed May 31, 2017
jquense pushed a commit that referenced this issue Jun 12, 2017
* Incorporated development + production builds into /dist (#64) and
updated Readme to include CDN/External information.

* Dropping references to Webpack specific build configurations in Readme
and adding clarity for CDN/external.
jquense added a commit that referenced this issue Jun 12, 2017
* Initial

* clean up prop names

* more exploration

* fun children

* fix tests

* some comment docs

* Incorporated development + production builds into /dist (#64) (#66)

* Incorporated development + production builds into /dist (#64) and
updated Readme to include CDN/External information.

* Dropping references to Webpack specific build configurations in Readme
and adding clarity for CDN/external.

* Enhancement for best practice prop types. (#70)

* Fixes #69: Adding capability to reduce production build output size and
allow users that import this package to include prop types in
development and optionally remove them using Webpacks UglifyJS + Define
plugin.

* Updated .babelrc that properly wraps prop-types.

* Restoring the original constant declaration for prop types as uglify
does find dead code and remove it.

* Updating changelog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant