[Feature] Add capability to remove prop types for extending applications #69
Comments
virgofx
added a commit
to virgofx/react-transition-group
that referenced
this issue
Jun 3, 2017
… size and allow users that import this package to include prop types in development and optionally remove them using Webpacks UglifyJS + Define plugin.
jquense
pushed a commit
that referenced
this issue
Jun 12, 2017
* Fixes #69: Adding capability to reduce production build output size and allow users that import this package to include prop types in development and optionally remove them using Webpacks UglifyJS + Define plugin. * Updated .babelrc that properly wraps prop-types. * Restoring the original constant declaration for prop types as uglify does find dead code and remove it. * Updating changelog.
jquense
pushed a commit
that referenced
this issue
Jun 12, 2017
* Fixes #69: Adding capability to reduce production build output size and allow users that import this package to include prop types in development and optionally remove them using Webpacks UglifyJS + Define plugin. * Updated .babelrc that properly wraps prop-types. * Restoring the original constant declaration for prop types as uglify does find dead code and remove it. * Updating changelog.
jquense
pushed a commit
that referenced
this issue
Jun 12, 2017
* Fixes #69: Adding capability to reduce production build output size and allow users that import this package to include prop types in development and optionally remove them using Webpacks UglifyJS + Define plugin. * Updated .babelrc that properly wraps prop-types. * Restoring the original constant declaration for prop types as uglify does find dead code and remove it. * Updating changelog.
jquense
added a commit
that referenced
this issue
Jun 12, 2017
* Initial * clean up prop names * more exploration * fun children * fix tests * some comment docs * Incorporated development + production builds into /dist (#64) (#66) * Incorporated development + production builds into /dist (#64) and updated Readme to include CDN/External information. * Dropping references to Webpack specific build configurations in Readme and adding clarity for CDN/external. * Enhancement for best practice prop types. (#70) * Fixes #69: Adding capability to reduce production build output size and allow users that import this package to include prop types in development and optionally remove them using Webpacks UglifyJS + Define plugin. * Updated .babelrc that properly wraps prop-types. * Restoring the original constant declaration for prop types as uglify does find dead code and remove it. * Updating changelog.
This was referenced Sep 22, 2018
Merged
1 task
This was referenced Jan 7, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prop types in this package are static and included in both development and production. Best practice is to use the plugin babel-plugin-transform-react-remove-prop-types with mode wrap. This allows developers to use the development/ES/imported version with prop types or use the external version that is minified fully.
The text was updated successfully, but these errors were encountered: