Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support refs on children #9

Merged
merged 2 commits into from Jan 20, 2017
Merged

Support refs on children #9

merged 2 commits into from Jan 20, 2017

Conversation

jquense
Copy link
Collaborator

@jquense jquense commented Jan 20, 2017

No description provided.

@jquense
Copy link
Collaborator Author

jquense commented Jan 20, 2017

rel: #8

@@ -187,6 +189,11 @@ class TransitionGroup extends React.Component {
for (let key in this.state.children) {
let child = this.state.children[key];
if (child) {
let isCallbackRef = typeof child.ref === 'function';
warning(!child.ref || isCallbackRef,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just typeof child.ref !== 'string'? can ref be an empty string?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha, duh. not sure why I was making that so complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants