Increase landscape width of refguide content for readability #3009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmyksj
added a commit
to tmyksj/reactor-core
that referenced
this pull request
Apr 9, 2022
The reference guide #content div has `max-width: 62.5em`. This is a bit small for large screens in landscape mode. So, this commit increases the width. For landscape, in FHD window, ideally, `1920px` * `60%` + `8em (div's padding)` = `80em` is a required width for readability. For more wide window, the constant will be smaller than `60%` of the window's width. Thus, `max-width` is desirable to be maximum of `80em` and `60%` of a window. For portrait (phone), the changes for landscape doesn't affect for portrait because it changes `max-width` only. So, this commit set `max-width` to `max(80em, 60%)`. Fixes reactor#2784.
tmyksj
force-pushed
the
2784-increaseWidthOfRefguideContent
branch
from
983e92f
to
bd0afac
Compare
tmyksj
added a commit
to tmyksj/reactor-core
that referenced
this pull request
Apr 9, 2022
The reference guide #content div has `max-width: 62.5em`. This is a bit small for large screens in landscape mode. So, this commit increases the width. For landscape, in FHD window, ideally, `1920px` * `60%` + `8em (div's padding)` = `80em` is a required width for readability. For more wide window, the constant will be smaller than `60%` of the window's width. Thus, `max-width` is desirable to be maximum of `80em` and `60%` of a window. For portrait (phone), the changes for landscape doesn't affect for portrait because it changes `max-width` to be increase. So, this commit set `max-width` to `max(80em, 60%)`. Fixes reactor#2784.
tmyksj
force-pushed
the
2784-increaseWidthOfRefguideContent
branch
from
bd0afac
to
4037bad
Compare
The reference guide #content div has `max-width: 62.5em`. This is a bit small for large screens in landscape mode. So, this commit increases the width. For landscape, in FHD (1920x1080) window, ideally, `1920px` * `60%` + `8em (div's padding)` = `80em` is a required width for readability. For more wide window, the constant will be smaller than `60%` of the window's width. Thus, `max-width` is desirable to be maximum of `80em` and `60%` of a window. For portrait (phone), the changes for landscape doesn't affect for portrait because it changes `max-width` to be increase. So, this commit set `max-width` to `max(80em, 60%)`. Fixes reactor#2784.
tmyksj
force-pushed
the
2784-increaseWidthOfRefguideContent
branch
from
4037bad
to
d8bcc28
Compare
|
The mobile / portrait version will probably need a more in-depth investigation and separate issue... the width change in desktop / landscape mode looks good to me. if you want to try and investigate the above css issue in a separate PR, that will be greatly appreciated @tmyksj |
simonbasle
approved these changes
Apr 11, 2022
simonbasle
changed the title
|
Thank you very much for your review and approval.
Yes, I will try it. Could you give me the #issue, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #2784
I attempted to increase width of refguide content for readability as below. Could you review this, please?
For landscape
At first,
we cannot set
max-widthto60%because width may be smaller than62.5em, e.g., FHD (1920x1080) window's width is (1920px-20em (padding for header)) *60%=60em<62.5em.In FHD window, ideally,
1920px*60%+8em (div's padding)=80emis a required width for readability.For more wide window,
the constant will be smaller than
60%of the window's width.Thus,
max-widthis desirable to be maximum of80emand60%of a window.For portrait (phone)
The changes for landscape doesn't affect for portrait because it changes
max-widthto be increase.---
So, I set
max-widthtomax(80em, 60%).Note:
max()is supported by most popular browsers exclude Internet Explorer.https://developer.mozilla.org/en-US/docs/Web/CSS/max
Current: html.tar.gz
Modified: html.tar.gz